x/spend-sparrow
2
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix: switch to mockery instead of handcrafted stubs

Browse Source
This commit is contained in:
Tim Wundenberg
2024-10-04 23:54:32 +02:00
parent 4bc17c50a4
commit fd6c68a71b
6 changed files with 69 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

95
service/auth_test.go
View File

@@ -2,6 +2,7 @@ package service
import (
"me-fit/db"
m "me-fit/mocks"
"me-fit/types"
"errors"
@@ -11,45 +12,38 @@ import (
"github.com/google/uuid"
)
type DbAuthStub struct {
user *db.User
err error
}
func (d DbAuthStub) GetUser(email string) (*db.User, error) {
return d.user, d.err
}
func TestSignIn(t *testing.T) {
t.Parallel()
t.Run("should return user if password is correct", func(t *testing.T) {
t.Parallel()
salt := []byte("salt")
verifiedAt := time.Date(2020, 1, 2, 0, 0, 0, 0, time.UTC)
stub := DbAuthStub{
user: db.NewUser(
uuid.New(),
"test@test.de",
true,
&verifiedAt,
false,
GetHashPassword("password", salt),
salt,
time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC),
),
err: nil,
}
underTest := NewServiceAuthImpl(stub)
actualUser, err := underTest.SignIn("test@test.de", "password")
user := db.NewUser(
uuid.New(),
"test@test.de",
true,
&verifiedAt,
false,
GetHashPassword("password", salt),
salt,
time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC),
)
mockDbAuth := m.NewMockDbAuth(t)
mockDbAuth.EXPECT().GetUser("test@test.de").Return(user, nil)
underTest := NewServiceAuthImpl(mockDbAuth)
actualUser, err := underTest.SignIn(user.Email, "password")
if err != nil {
t.Errorf("Expected nil, got %v", err)
}
expectedUser := User{
Id: stub.user.Id,
Email: stub.user.Email,
EmailVerified: stub.user.EmailVerified,
Id: user.Id,
Email: user.Email,
EmailVerified: user.EmailVerified,
}
if *actualUser != expectedUser {
t.Errorf("Expected %v, got %v", expectedUser, actualUser)
@@ -60,20 +54,21 @@ func TestSignIn(t *testing.T) {
t.Parallel()
salt := []byte("salt")
verifiedAt := time.Date(2020, 1, 2, 0, 0, 0, 0, time.UTC)
stub := DbAuthStub{
user: db.NewUser(
uuid.New(),
"test@test.de",
true,
&verifiedAt,
false,
GetHashPassword("password", salt),
salt,
time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC),
),
err: nil,
}
underTest := NewServiceAuthImpl(stub)
user := db.NewUser(
uuid.New(),
"test@test.de",
true,
&verifiedAt,
false,
GetHashPassword("password", salt),
salt,
time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC),
)
mockDbAuth := m.NewMockDbAuth(t)
mockDbAuth.EXPECT().GetUser(user.Email).Return(user, nil)
underTest := NewServiceAuthImpl(mockDbAuth)
_, err := underTest.SignIn("test@test.de", "wrong password")
if err != ErrInvaidCredentials {
@@ -82,11 +77,10 @@ func TestSignIn(t *testing.T) {
})
t.Run("should return ErrInvalidCretentials if user has not been found", func(t *testing.T) {
t.Parallel()
stub := DbAuthStub{
user: nil,
err: db.ErrUserNotFound,
}
underTest := NewServiceAuthImpl(stub)
mockDbAuth := m.NewMockDbAuth(t)
mockDbAuth.EXPECT().GetUser("test").Return(nil, db.ErrUserNotFound)
underTest := NewServiceAuthImpl(mockDbAuth)
_, err := underTest.SignIn("test", "test")
if err != ErrInvaidCredentials {
@@ -95,11 +89,10 @@ func TestSignIn(t *testing.T) {
})
t.Run("should forward ErrInternal on any other error", func(t *testing.T) {
t.Parallel()
stub := DbAuthStub{
user: nil,
err: errors.New("Some error"),
}
underTest := NewServiceAuthImpl(stub)
mockDbAuth := m.NewMockDbAuth(t)
mockDbAuth.EXPECT().GetUser("test").Return(nil, errors.New("Some error"))
underTest := NewServiceAuthImpl(mockDbAuth)
_, err := underTest.SignIn("test", "test")
if err != types.ErrInternal {