fix(observabillity): set service.name resource on metrics and traces
This commit was merged in pull request #188.
This commit is contained in:
@@ -59,7 +59,7 @@ func setupOTelSDK(ctx context.Context) (func(context.Context) error, error) {
|
||||
}
|
||||
|
||||
// Set up trace provider.
|
||||
tracerProvider, err := newTracerProvider(ctx)
|
||||
tracerProvider, err := newTracerProvider(ctx, resources)
|
||||
if err != nil {
|
||||
handleErr(ctx, err)
|
||||
return nil, err
|
||||
@@ -68,7 +68,7 @@ func setupOTelSDK(ctx context.Context) (func(context.Context) error, error) {
|
||||
otel.SetTracerProvider(tracerProvider)
|
||||
|
||||
// Set up meter provider.
|
||||
meterProvider, err := newMeterProvider(ctx)
|
||||
meterProvider, err := newMeterProvider(ctx, resources)
|
||||
if err != nil {
|
||||
handleErr(ctx, err)
|
||||
return nil, err
|
||||
@@ -95,7 +95,7 @@ func newPropagator() propagation.TextMapPropagator {
|
||||
)
|
||||
}
|
||||
|
||||
func newTracerProvider(ctx context.Context) (*trace.TracerProvider, error) {
|
||||
func newTracerProvider(ctx context.Context, resource *resource.Resource) (*trace.TracerProvider, error) {
|
||||
exp, err := otlptracegrpc.New(
|
||||
ctx,
|
||||
otlptracegrpc.WithEndpoint(otelEndpoint),
|
||||
@@ -105,10 +105,13 @@ func newTracerProvider(ctx context.Context) (*trace.TracerProvider, error) {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
return trace.NewTracerProvider(trace.WithBatcher(exp)), nil
|
||||
return trace.NewTracerProvider(
|
||||
trace.WithBatcher(exp),
|
||||
trace.WithResource(resource),
|
||||
), nil
|
||||
}
|
||||
|
||||
func newMeterProvider(ctx context.Context) (*metric.MeterProvider, error) {
|
||||
func newMeterProvider(ctx context.Context, resource *resource.Resource) (*metric.MeterProvider, error) {
|
||||
exp, err := otlpmetricgrpc.New(
|
||||
ctx,
|
||||
otlpmetricgrpc.WithInsecure(),
|
||||
@@ -118,9 +121,9 @@ func newMeterProvider(ctx context.Context) (*metric.MeterProvider, error) {
|
||||
}
|
||||
|
||||
return metric.NewMeterProvider(
|
||||
metric.WithReader(
|
||||
metric.NewPeriodicReader(
|
||||
exp, metric.WithInterval(15*time.Second)))), nil
|
||||
metric.WithReader(metric.NewPeriodicReader(exp, metric.WithInterval(15*time.Second))),
|
||||
metric.WithResource(resource),
|
||||
), nil
|
||||
}
|
||||
|
||||
func newLoggerProvider(ctx context.Context, resource *resource.Resource) (*log.LoggerProvider, error) {
|
||||
|
||||
Reference in New Issue
Block a user