feat(security): #328 delete old sessions for change and forgot password

2024-12-17 22:21:46 +01:00
parent 43d0a3d022
commit dcc5207272
13 changed files with 292 additions and 120 deletions
--- a/main_test.go
+++ b/main_test.go
@@ -11,6 +11,7 @@ import (
 	"testing"
 	"time"

+	"me-fit/db"
 	"me-fit/service"
 	"me-fit/types"

@@ -81,13 +82,13 @@ func TestIntegrationSecurityHeader(t *testing.T) {
 		assert.Equal(t, "GET, POST, DELETE", value)

 		value = resp.Header.Get("Content-Security-Policy")
-		assert.Equal(t, "default-src 'none';"+
-			"script-src 'self' https://umami.me-fit.eu"+
-			"connect-src 'self' https://umami.me-fit.eu"+
-			"img-src 'self'"+
-			"style-src 'self'"+
-			"form-action 'self'"+
-			"frame-ancestors 'none'", value)
+		assert.Equal(t, "default-src 'none'; "+
+			"script-src 'self' https://umami.me-fit.eu; "+
+			"connect-src 'self' https://umami.me-fit.eu; "+
+			"img-src 'self'; "+
+			"style-src 'self'; "+
+			"form-action 'self'; "+
+			"frame-ancestors 'none';", value)

 		value = resp.Header.Get("Cross-Origin-Resource-Policy")
 		assert.Equal(t, "same-origin", value)
@@ -159,6 +160,138 @@ func TestIntegrationAuth(t *testing.T) {
 		assert.True(t, cookie.HttpOnly, "Cookie is not secure")
 		assert.True(t, cookie.Secure, "Cookie is not secure")
 	})
+	t.Run("should change password and invalidate other sessions from user", func(t *testing.T) {
+		t.Parallel()
+
+		db, basePath, ctx := setupIntegrationTest(t)
+		userId := uuid.New()
+		userIdOther := uuid.New()
+
+		pass := service.GetHashPassword("password", []byte("salt"))
+		_, err := db.Exec(`
+			INSERT INTO user (user_id, email, email_verified, is_admin, password, salt, created_at) 
+			VALUES (?, "mail@mail.de", FALSE, FALSE, ?, ?, datetime())`, userId, pass, []byte("salt"))
+
+		sessionId := "session-id"
+		assert.Nil(t, err)
+		_, err = db.Exec(`
+			INSERT INTO session (session_id, user_id, created_at, expires_at)
+			VALUES (?, ?, datetime(), datetime("now", "+1 day"))`, sessionId, userId)
+		assert.Nil(t, err)
+		_, err = db.Exec(`
+			INSERT INTO session (session_id, user_id, created_at, expires_at)
+			VALUES ("second", ?, datetime(), datetime("now", "+1 day"))`, userId)
+		assert.Nil(t, err)
+		_, err = db.Exec(`
+			INSERT INTO session (session_id, user_id, created_at, expires_at)
+			VALUES ("other", ?, datetime(), datetime("now", "+1 day"))`, userIdOther)
+		assert.Nil(t, err)
+
+		req, err := http.NewRequestWithContext(ctx, "GET", basePath+"/auth/change-password", nil)
+		assert.Nil(t, err)
+		req.Header.Set("Cookie", "id="+sessionId)
+		resp, err := httpClient.Do(req)
+		assert.Nil(t, err)
+
+		html, err := html.Parse(resp.Body)
+		assert.Nil(t, err)
+
+		csrfToken := findCsrfToken(html)
+		assert.NotEqual(t, "", csrfToken)
+
+		formData := url.Values{
+			"current-password": {"password"},
+			"new-password":     {"MyNewSecurePassword1!"},
+			"csrf-token":       {csrfToken},
+		}
+
+		req, err = http.NewRequestWithContext(ctx, "POST", basePath+"/api/auth/change-password", strings.NewReader(formData.Encode()))
+		assert.Nil(t, err)
+		req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+		req.Header.Set("Cookie", "id="+sessionId)
+		req.Header.Set("HX-Request", "true")
+		resp, err = httpClient.Do(req)
+		assert.Nil(t, err)
+
+		assert.Equal(t, http.StatusOK, resp.StatusCode)
+
+		var sessionIds []string
+		sessions, err := db.Query(`SELECT session_id FROM session WHERE NOT user_id = ? ORDER BY session_id`, uuid.Nil)
+		assert.Nil(t, err)
+		for sessions.Next() {
+			var sessionId string
+			err = sessions.Scan(&sessionId)
+			assert.Nil(t, err)
+			sessionIds = append(sessionIds, sessionId)
+		}
+
+		assert.Equal(t, 2, len(sessionIds))
+		assert.Equal(t, "other", sessionIds[0])
+		assert.Equal(t, "session-id", sessionIds[1])
+	})
+	t.Run("should forget password and invalidate all user sessions", func(t *testing.T) {
+		t.Parallel()
+
+		d, basePath, ctx := setupIntegrationTest(t)
+		userId := uuid.New()
+
+		pass := service.GetHashPassword("password", []byte("salt"))
+		_, err := d.Exec(`
+			INSERT INTO user (user_id, email, email_verified, is_admin, password, salt, created_at) 
+			VALUES (?, "mail@mail.de", FALSE, FALSE, ?, ?, datetime())`, userId, pass, []byte("salt"))
+
+		assert.Nil(t, err)
+		_, err = d.Exec(`
+			INSERT INTO session (session_id, user_id, created_at, expires_at)
+			VALUES ("session-id", ?, datetime(), datetime("now", "+1 day"))`, userId)
+		assert.Nil(t, err)
+
+		req, err := http.NewRequestWithContext(ctx, "GET", basePath+"/auth/forgot-password", nil)
+		assert.Nil(t, err)
+		resp, err := httpClient.Do(req)
+		assert.Nil(t, err)
+
+		sessionId := findCookie(resp, "id").Value
+		html, err := html.Parse(resp.Body)
+		assert.Nil(t, err)
+		csrfToken := findCsrfToken(html)
+		assert.NotEqual(t, "", csrfToken)
+
+		formData := url.Values{
+			"email":      {"mail@mail.de"},
+			"csrf-token": {csrfToken},
+		}
+		req, err = http.NewRequestWithContext(ctx, "POST", basePath+"/api/auth/forgot-password", strings.NewReader(formData.Encode()))
+		assert.Nil(t, err)
+		req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+		req.Header.Set("Cookie", "id="+sessionId)
+		req.Header.Set("HX-Request", "true")
+		resp, err = httpClient.Do(req)
+		assert.Nil(t, err)
+		assert.Equal(t, http.StatusOK, resp.StatusCode)
+
+		var token string
+		err = d.QueryRow("SELECT token FROM token WHERE type = ?", db.TokenTypePasswordReset).Scan(&token)
+		assert.Nil(t, err)
+
+		formData = url.Values{
+			"new-password": {"MyNewSecurePassword1!"},
+			"csrf-token":   {csrfToken},
+		}
+		req, err = http.NewRequestWithContext(ctx, "POST", basePath+"/api/auth/forgot-password-actual", strings.NewReader(formData.Encode()))
+		assert.Nil(t, err)
+		req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+		req.Header.Set("Cookie", "id="+sessionId)
+		req.Header.Set("HX-Request", "true")
+		req.Header.Set("HX-Current-URL", basePath+"/auth/change-password?token="+url.QueryEscape(token))
+		resp, err = httpClient.Do(req)
+		assert.Nil(t, err)
+		assert.Equal(t, http.StatusOK, resp.StatusCode)
+
+		sessions, err := d.Query("SELECT session_id FROM session WHERE user_id = ?", userId)
+		assert.Nil(t, err)
+		assert.False(t, sessions.Next())
+	})
 }

 func findCookie(resp *http.Response, name string) *http.Cookie {